Skip to content

[compatibility]Add skip_min_kubelet_versions #35949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[compatibility]Add skip_min_kubelet_versions #35949

wants to merge 1 commit into from
+32 −11

Conversation

@siyuanfoundation
Copy link
Contributor

@siyuanfoundation siyuanfoundation commented Nov 21, 2025

revert #35923 to use SKIP MinimumKubeletVersion instead

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 21, 2025
@siyuanfoundation
Copy link
Contributor Author

siyuanfoundation commented Nov 21, 2025

/cc @BenTheElder @Jefftree @michaelasp

BenTheElder
BenTheElder reviewed Nov 21, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

I wonder if it might make sense to just skip all MinimumKubeletVersion to simplify for now, it's relatively few tests and the feature we're testing isn't aimed at kubelet.

We should probably come up with a better way to express this in Kubernetes, maybe we can do something smarter with ginkgo label filtering ... cc @pohly @aojea @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation
Copy link
Contributor Author

siyuanfoundation commented Nov 21, 2025

I wonder if it might make sense to just skip all MinimumKubeletVersion to simplify for now, it's relatively few tests and the feature we're testing isn't aimed at kubelet.

If we are testing skip upgrade from 1.34 to 1.36, we would still want to test all the test cases with MinimumKubeletVersion=1.34. So I think skip all MinimumKubeletVersion would be too simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@aojea aojea Awaiting requested review from aojea

@Jefftree Jefftree Awaiting requested review from Jefftree

@michaelasp michaelasp Awaiting requested review from michaelasp

Assignees

@BenTheElder BenTheElder

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siyuanfoundation @k8s-ci-robot @BenTheElder